TST: Add interval closed fixture to top-level conftest #21595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #21595 +/- ##
=======================================
Coverage 91.9% 91.9%
=======================================
Files 153 153
Lines 49549 49549
=======================================
Hits 45539 45539
Misses 4010 4010
Continue to review full report at Codecov.
|
|
thanks. its possible this might conflict with 'closed' as used in thinks like |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed identical copies of this fixture in multiple places, so seemed reasonable to dedupe and move to the top-level
conftest.py. I think I removed all instances of such a fixture/parametrize being used, but could have missed one. I imagine this fixture will be used in more places in the future when interval related tests are expanded.